theirix opened a new pull request, #21409:
URL: https://github.com/apache/datafusion/pull/21409

   ## Which issue does this PR close?
   
   ## Rationale for this change
   
   Spin-off of #21383 to have a bench for `First_Value`, `Last_Value` available 
before a PR with logic change.
   
   ## What changes are included in this PR?
   
   - Add benchmark for `GroupsAccumulator`. It's pretty complicated to test 
aggregates with grouping, since many operations are stateful, so I introduced 
end-to-end evaluate test (to actually test taking state) and convert_to_state 
(as in other benches)
   - A bench for a simple `Accumulator`
   
   ## Are these changes tested?
   
   - Manual bench run
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to