comphead commented on code in PR #3629:
URL: https://github.com/apache/datafusion-comet/pull/3629#discussion_r3046115551
##########
native/core/src/execution/jni_api.rs:
##########
@@ -393,6 +393,11 @@ fn prepare_datafusion_session_context(
// register UDFs from datafusion-spark crate
fn register_datafusion_spark_function(session_ctx: &SessionContext) {
+ // Don't register SparkArrayRepeat — it returns NULL when the element is
NULL
+ // (e.g. array_repeat(null, 3) returns NULL instead of [null, null, null]).
+ // Comet's Scala serde wraps the call in a CaseWhen for null count
handling,
+ // so DataFusion's built-in ArrayRepeat is sufficient.
+ // TODO: file upstream issue against datafusion-spark
Review Comment:
this is one of datafusion spark built in issues? perhaps we can just
fallback in this case like we do for other spark builtin functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
