alamb commented on code in PR #11556:
URL: https://github.com/apache/datafusion/pull/11556#discussion_r1685729845
##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -54,6 +57,7 @@ impl RegexpReplaceFunc {
signature: Signature::one_of(
vec![
Exact(vec![Utf8, Utf8, Utf8]),
+ Exact(vec![Utf8View, Utf8, Utf8]),
Review Comment:
Yeah -- this is the kind of things that the LogicalType proposal
https://github.com/apache/datafusion/issues/11513 https://github.com/notfilippo
would I think make eaiser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
