kosiew commented on code in PR #21227:
URL: https://github.com/apache/datafusion/pull/21227#discussion_r3050606666
##########
.github/workflows/extended.yml:
##########
@@ -57,37 +57,9 @@ permissions:
checks: write
jobs:
-
- # Check crate compiles and base cargo check passes
- linux-build-lib:
- name: linux build test
- runs-on: ${{ github.repository_owner == 'apache' &&
format('runs-on={0},family=m8a+m7a+c8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion',
github.run_id) || 'ubuntu-latest' }}
- # note: do not use amd/rust container to preserve disk space
- steps:
- - uses: runs-on/action@cd2b598b0515d39d78c38a02d529db87d2196d1e # v2.0.3
- - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #
v6.0.2
- with:
- ref: ${{ github.event.inputs.pr_head_sha }} # will be empty if
triggered by push
- submodules: true
- fetch-depth: 1
- - name: Install Rust
- run: |
- curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s --
-y
- source $HOME/.cargo/env
- rustup toolchain install
- - name: Install Protobuf Compiler
Review Comment:
Removing `linux-build-lib` seems like a good tradeoff to help unblock the
long-running extended suite sooner.
Since the deleted job was still carrying the same ad hoc Rust/protobuf
bootstrap that `linux-test-extended` keeps below, could we do a follow-up and
move that setup into `./.github/actions/setup-builder` or another shared helper?
I think that would make future CI environment changes a little easier to
manage in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
