haohuaijin commented on code in PR #21460:
URL: https://github.com/apache/datafusion/pull/21460#discussion_r3052205798


##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -2572,4 +2576,67 @@ mod tests {
         );
         Ok(())
     }
+
+    /// Regression test: ProjectionExec on top of a FilterExec that already has

Review Comment:
   for more context how we find this bug. in our use case, we first use sql to 
generate the physical plan, then apply some plan rewrite, then apply some 
physical optimizer rule.
   
   for this bug, after generate physical plan, we remove the FilterExec, but 
the FilterExec have the projection, so it leaves a ProjectionExec, then in the 
datasourceExec, we add a FilterExec in top of it. so the final plan is look like
   ```
   ProjectionExec
       FilterExec
           DataSourceExec
   ```
   for abvoe plan, we run the `ProjectionPushdown` that find this bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to