tshauck commented on code in PR #11584:
URL: https://github.com/apache/datafusion/pull/11584#discussion_r1685768971
##########
datafusion/functions/src/math/monotonicity.rs:
##########
@@ -15,24 +15,17 @@
// specific language governing permissions and limitations
// under the License.
-use arrow::datatypes::DataType;
use datafusion_common::{exec_err, Result, ScalarValue};
use datafusion_expr::interval_arithmetic::Interval;
use datafusion_expr::sort_properties::{ExprProperties, SortProperties};
-fn symmetric_unit_interval(data_type: &DataType) -> Result<Interval> {
Review Comment:
because this is also used in the bounds code, I added a constructor on
`Interval`. I wasn't sure about adding others (e.g.
`Interval::make_symmetric_pi_interval`) since right now they're only also used
in the bounds code, but it would clean up that code + tests a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
