Weijun-H commented on code in PR #11542:
URL: https://github.com/apache/datafusion/pull/11542#discussion_r1685919319
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -112,7 +112,24 @@ impl ExprSchemable for Expr {
Expr::OuterReferenceColumn(ty, _) => Ok(ty.clone()),
Expr::ScalarVariable(ty, _) => Ok(ty.clone()),
Expr::Literal(l) => Ok(l.data_type()),
- Expr::Case(case) => case.when_then_expr[0].1.get_type(schema),
+ // Expr::Case(case) => case.when_then_expr[0].1.get_type(schema),
+ Expr::Case(case) => {
+ for (_, then_expr) in &case.when_then_expr {
+ let then_type = then_expr.get_type(schema)?;
+ if !then_type.is_null() {
+ return Ok(then_type);
+ }
+ }
Review Comment:
return first non-null then type here @jonahgao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
