alamb commented on PR #21456: URL: https://github.com/apache/datafusion/pull/21456#issuecomment-4226341190
> Query 0 in clickbench_extended dataset (which uses count distinct on u8 is now ~ 11 % faster : THe benchmark runner doesn't seem to be able to reproduce that result 🤔 Also the microbenchmarks seem to still show a 10% slowdown: https://github.com/apache/datafusion/pull/21456#issuecomment-4225505082 For i64 which isn't changed by this patch ``` count_distinct i64 80% distinct 1.00 101.5±0.26µs ? ?/sec 1.11 112.9±0.36µs ? ?/sec count_distinct i64 99% distinct 1.00 102.1±0.21µs ? ?/sec 1.13 115.1±0.46µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
