mbutrovich commented on code in PR #3688:
URL: https://github.com/apache/datafusion-comet/pull/3688#discussion_r3066704518
##########
native/core/src/execution/jni_api.rs:
##########
@@ -649,10 +653,16 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_executePlan(
// Retrieve the query
let exec_context = get_execution_context(exec_context);
- let tracing_event_name = exec_context.tracing_event_name.clone();
let tracing_enabled = exec_context.tracing_enabled;
-
- let result = with_trace(&tracing_event_name, tracing_enabled, || {
+ let tracing_event_name;
+ let tracing_label = if tracing_enabled {
+ tracing_event_name = exec_context.tracing_event_name.clone();
+ tracing_event_name.as_str()
Review Comment:
Is this assigning to the same thing twice? It's getting late in the day for
me so I might be misreading it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
