hsiang-c commented on code in PR #3706: URL: https://github.com/apache/datafusion-comet/pull/3706#discussion_r3066759014
########## spark/src/test/resources/sql-tests/expressions/array/sort_array.sql: ########## @@ -0,0 +1,199 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agreements. See the NOTICE file +-- distributed with this work for additional information +-- regarding copyright ownership. The ASF licenses this file +-- to you under the Apache License, Version 2.0 (the +-- "License"); you may not use this file except in compliance +-- with the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, +-- software distributed under the License is distributed on an +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +-- KIND, either express or implied. See the License for the +-- specific language governing permissions and limitations +-- under the License. + +-- ConfigMatrix: parquet.enable.dictionary=false,true + +statement +CREATE TABLE test_sort_array_int(arr array<int>) USING parquet + +statement +INSERT INTO test_sort_array_int VALUES + (array(3, 1, 4, 1, 5)), + (array(3, NULL, 1, NULL, 2)), + (array()), + (NULL) + +query +SELECT sort_array(arr) FROM test_sort_array_int + +query +SELECT sort_array(arr, true) FROM test_sort_array_int + +query +SELECT sort_array(arr, false) FROM test_sort_array_int + +statement +CREATE TABLE test_sort_array_string(arr array<string>) USING parquet + +statement +INSERT INTO test_sort_array_string VALUES + (array('d', 'c', 'b', 'a')), + (array('b', NULL, 'a')), + (array()), + (NULL) + +query +SELECT sort_array(arr) FROM test_sort_array_string + +query +SELECT sort_array(arr, true) FROM test_sort_array_string + +query +SELECT sort_array(arr, false) FROM test_sort_array_string + +statement +CREATE TABLE test_sort_array_float(arr array<double>) USING parquet + +statement +INSERT INTO test_sort_array_float VALUES + (array(CAST('NaN' AS DOUBLE), 3.0, 1.0, NULL, -0.0, 0.0)), + (array(CAST('NaN' AS DOUBLE), CAST('NaN' AS DOUBLE), -5.0, 2.0)), + (array()), + (NULL) + +query +SELECT sort_array(arr) FROM test_sort_array_float + +query +SELECT sort_array(arr, true) FROM test_sort_array_float + +query +SELECT sort_array(arr, false) FROM test_sort_array_float + +statement +CREATE TABLE test_sort_array_decimal(arr array<decimal(10, 0)>) USING parquet + +statement +INSERT INTO test_sort_array_decimal VALUES + (array(CAST(100 AS DECIMAL(10, 0)), CAST(10 AS DECIMAL(10, 0)))), Review Comment: Perhaps we can add a test with the same value but with different decimal precision and scale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
