alamb commented on code in PR #1486:
URL:
https://github.com/apache/datafusion-python/pull/1486#discussion_r3066875693
##########
.github/workflows/verify-release-candidate.yml:
##########
@@ -73,6 +73,11 @@ jobs:
version: "27.4"
repo-token: ${{ secrets.GITHUB_TOKEN }}
+ - name: Set RUSTFLAGS for Windows GNU linker
+ if: matrix.os == 'windows'
+ shell: bash
+ run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >>
"$GITHUB_ENV"
Review Comment:
the title of this PR says it is setting the linker to msvc but this seems to
actually to disable automatic symbol export
https://linux.die.net/man/1/ld
```
--exclude-libs lib,lib,...
Specifies a list of archive libraries from which symbols should not be
automatically exported. The library names may be delimited by commas or colons.
Specifying "--exclude-libs ALL" excludes symbols in all archive libraries from
automatic export. This option is available only for the i386 PE targeted port
of the linker and for ELF targeted ports. For i386 PE , symbols explicitly
listed in a .def file are still exported, regardless of this option. For ELF
targeted ports, symbols affected by this option will be treated as hidden.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
