2010YOUY01 commented on code in PR #21549: URL: https://github.com/apache/datafusion/pull/21549#discussion_r3068835060
########## datafusion/sqllogictest/test_files/eliminate_outer_join.slt: ########## @@ -198,6 +198,133 @@ select * from t1 left join t2 on t1.a = t2.x where t2.x in (1, 2) or t2.x is nul 3 30 c NULL NULL NULL NULL 40 d NULL NULL NULL +### Review Comment: It would be great to add a few more tests: - FULL JOINs (covering FULL -> INNER / LEFT / RIGHT depending on which side is null-rejecting — not sure if all cases are implemented yet 🤔) - Nested predicates with `AND` / `OR` Some basic mixed-predicate cases would be good, as I assume they’re already extensively tested before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
