Dandandan opened a new pull request, #21567:
URL: https://github.com/apache/datafusion/pull/21567
## Which issue does this PR close?
N/A - Performance optimization
## Rationale for this change
The `vectorized_append_inner` method in `ByteViewGroupValueBuilder` was
using `make_view` to reconstruct views from scratch, which involves re-reading
the value bytes to build the prefix. This is unnecessary since the input array
already has correctly formed views that contain the length and prefix.
## What changes are included in this PR?
- Reuse input array views directly instead of calling `make_view`:
- For inline values (len <= 12), copy the view as-is
- For non-inline values, copy data and update buffer_index/offset using
`ByteView`'s builder API
- Switch `Nulls::None` and `Nulls::Some` branches from `for` loops to
`extend`
- Extract shared `copy_from_view` helper
- Remove now-unused `do_append_val_inner` and
`ensure_in_progress_big_enough` methods
- Remove unused `make_view` import
## Are these changes tested?
Existing tests cover the functionality. Verified with `cargo check` and
`cargo clippy`.
## Are there any user-facing changes?
No - internal performance optimization only.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
