andygrove commented on code in PR #3930:
URL: https://github.com/apache/datafusion-comet/pull/3930#discussion_r3069679337
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -77,6 +77,9 @@ pub struct ScanExec {
baseline_metrics: BaselineMetrics,
/// Whether native code can assume ownership of batches that it receives
arrow_ffi_safe: bool,
+ /// When true, input comes from a CometHandleBatchIterator and batches are
+ /// retrieved from the BatchStash instead of via Arrow FFI import.
+ pub handle_mode: bool,
Review Comment:
We should probably combine `arrow_ffi_safe` and `handle_mode` and use an
enum, but I would prefer to do that as a follow on PR. Something like:
```
enum TransferMode {
FfiSafe,
FfiUnsafe,
Handle
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
