adriangb commented on PR #21563: URL: https://github.com/apache/datafusion/pull/21563#issuecomment-4232862650
> Thanks @adriangb for pinging me, in Comet we would need to adapt to the changes, if I understood the changes we would need to use `CastExpr` instead of `CastColumnExpr` ? Yes I just checked and it seems like you’re actually using neither. Searching the codebase for `CastColumnExpr` all I found was your custom implementation: https://github.com/apache/datafusion-comet/blob/88c1ffcd083eb05bcbdcc85090e53b3398850946/native/core/src/parquet/cast_column.rs#L181. Now that `CastExpr` is more capable maybe you can just use that? You do use `CastExpr` but that shouldn’t change: https://github.com/apache/datafusion-comet/blob/88c1ffcd083eb05bcbdcc85090e53b3398850946/native/core/src/execution/planner.rs#L1991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
