RafaelHerrero opened a new pull request, #21578:
URL: https://github.com/apache/datafusion/pull/21578

   ## Which issue does this PR close?
   
   Related to #6543 and #21260
   
   ## Rationale for this change
   
   The `regenerate_sqlite_files.sh` script swaps in a forked version of 
`sqllogictest-rs` (Omega359/sqllogictest-rs v0.27.2) before running test 
completion. This fork added valuewise result mode, valuesort, and custom 
normalizer support.
   
   These features were upstreamed to `risinglightdb/sqllogictest-rs` in v0.24.0 
([PR #237](https://github.com/risinglightdb/sqllogictest-rs/pull/237)). 
DataFusion already uses upstream v0.29.1 which includes everything, so the fork 
swap is no longer needed.
   
   ## What changes are included in this PR?
   
   - Remove the `Cargo.toml` dependency swap to the Omega359 fork (line 167)
   - Remove the `bin/sqllogictests.rs` file swap with the custom regenerate 
version (line 172)
   - Remove the cleanup steps that reverted those swaps (lines 203-204)
   - Update the script description to reflect the simplified flow
   
   ## Are these changes tested?
   
   The script has valid bash syntax. The change is purely removing dead code — 
the fork features are already available in the upstream version DataFusion uses.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to