gstvg commented on code in PR #18921: URL: https://github.com/apache/datafusion/pull/18921#discussion_r3074576663
########## datafusion/physical-expr/src/expressions/lambda_variable.rs: ########## @@ -0,0 +1,155 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Physical lambda variable reference: [`LambdaVariable`] + +use std::any::Any; +use std::hash::Hash; +use std::sync::Arc; + +use crate::physical_expr::PhysicalExpr; +use arrow::datatypes::FieldRef; +use arrow::{ + datatypes::{DataType, Schema}, + record_batch::RecordBatch, +}; + +use datafusion_common::{Result, internal_err, plan_err}; +use datafusion_expr::ColumnarValue; + +/// Represents the lambda variable with a given name and field +#[derive(Debug, Clone)] +pub struct LambdaVariable { + name: String, Review Comment: included at https://github.com/apache/datafusion/pull/18921/changes/2259f70e727d61b8e0e02f01556635fedf694891 I copied from the logical counterpart (where I think we should make the field optional as in Expr::Placeholder, and keep a dedicated name ) without realizing we could use the field name here, thanks ########## datafusion/expr/src/type_coercion/functions.rs: ########## @@ -148,6 +151,81 @@ pub fn fields_with_udf<F: UDFCoercionExt>( .collect()) } +/// Performs type coercion for higher order function arguments. +/// +/// For value arguments, returns the field to which each +/// argument must be coerced to match `signature`. +/// For lambda arguments, returns a clone of the associated data +/// +/// For more details on coercion in general, please see the +/// [`type_coercion`](crate::type_coercion) module. +pub fn value_fields_with_higher_order_udf<L: Clone>( Review Comment: https://github.com/apache/datafusion/pull/18921/changes/474b22ec42bfa62531cc4072accb4b9b5632e472 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
