yonatan-sevenai commented on PR #20648: URL: https://github.com/apache/datafusion/pull/20648#issuecomment-4239517732
Hi @goldmedal. Apparently both of us implemented Unparser support for snowflake, with a somewhat different approach. I'd love if you can take a look at https://github.com/apache/datafusion/pull/21593. Specifically, did you have a chance to test complex expressions where (for example) the array to unnest is the result of a UDF, Subquery, and things like that? I saw a lot of edge cases where the optimizer might include limits and sorts between the unnest and the TableScan / SubqueryAlias as well and some complexity when you need to cross join the original table. There's a ton of test cases in my PR above, which I'd love your thoughts one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
