adamreeve opened a new issue, #21602: URL: https://github.com/apache/datafusion/issues/21602
The `ConfigFileDecryptionProperties` type implements [`From<&Arc<FileDecryptionProperties>>`](https://github.com/apache/datafusion/blob/e0fd16ee3fc88e58f8c3e2f63a43ccf3d4ab2f9e/datafusion/common/src/config.rs#L3027) But `ConfigFileDecryptionProperties` is unable to represent decryption properties that use a key retriever to dynamically retrieve keys. If the `FileDecryptionProperties` uses a key retriever, trying to get the footer key will fail and a default empty key will be silently used: https://github.com/apache/datafusion/blob/e0fd16ee3fc88e58f8c3e2f63a43ccf3d4ab2f9e/datafusion/common/src/config.rs#L3044 This can lead to unexpected behaviour and hard to track down bugs. We should instead implement `TryFrom` so it's clear that this can fail, and return a helpful error on failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
