kumarUjjawal opened a new pull request, #21615:
URL: https://github.com/apache/datafusion/pull/21615
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #21368.
## Rationale for this change
TPC-H query 11 was using a fixed `0.0001` threshold in the HAVING clause.
Per the TPC-H spec, this value must be `0.0001 / SF`.
This means the benchmark query is only correct for scale factor 1. For
larger scale factors the filter becomes too
strict, and for smaller scale factors it becomes too loose.
There are also few benchmark queries using fixed end dates where the spec
uses `date + interval`. Those are equivalent but using intervals matches the
TPC-H query definitions more closely.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
- Make TPC-H query 11 use scale-factor substitution.
- Add scale factor support in the benchmark runner.
- Infer scale factor from dataset paths like `tpch_sf10`.
- Pass the scale factor from `bench.sh`.
- Keep the old query-loading entry point working with the
default scale factor of 1.
- Update query 5, 6, 10, 12, and 14 to use interval-based
date ranges.
- Add regression tests for scale-factor substitution,
scale-factor parsing, and invalid scale factors.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
TPC-H benchmark query 11 now returns correct results when the scale factor
is not 1.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
