alamb commented on PR #11550: URL: https://github.com/apache/datafusion/pull/11550#issuecomment-2243519481
I looked at https://github.com/apache/datafusion/pull/11582 and after reading the rest of the commentary on this PR I think this PR's proposal is best approach Thus I suggest: 1. Get this PR ready for review 2. Add some sort of backwards compatibility thing to help migration Backwards compatibilty: basically give a deprecation message that tells users how to upgrade For example, something like ```rust // Compatibility: ensure existing users of AggregateExt get a message about ExprFunctionExt // Note the syntax isn't quite right for the deprecated macro #[deprecated(version = 40, message=:"ExprFunctionExt instead")] trait AggregateExt: ExprFunctionExt {} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
