kazuyukitanimura commented on code in PR #3892:
URL: https://github.com/apache/datafusion-comet/pull/3892#discussion_r3080557256


##########
spark/src/test/resources/sql-tests/expressions/aggregate/corr.sql:
##########
@@ -29,3 +28,13 @@ SELECT corr(x, y) FROM test_corr
 
 query tolerance=1e-6
 SELECT grp, corr(x, y) FROM test_corr GROUP BY grp ORDER BY grp
+
+-- Test permutations of NULL and NaN
+statement
+CREATE TABLE test_corr_nan(x double, y double, grp string) USING parquet
+
+statement
+INSERT INTO test_corr_nan VALUES (cast('NaN' as double), cast('NaN' as 
double), 'both_nan'), (cast('NaN' as double), 1.0, 'nan_val'), (1.0, cast('NaN' 
as double), 'val_nan'), (NULL, cast('NaN' as double), 'null_nan'), (cast('NaN' 
as double), NULL, 'nan_null'), (NULL, NULL, 'both_null'), (NULL, 1.0, 
'null_val'), (1.0, NULL, 'val_null')

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to