alamb commented on code in PR #11602: URL: https://github.com/apache/datafusion/pull/11602#discussion_r1686974239
########## datafusion/core/src/lib.rs: ########## @@ -569,10 +569,10 @@ pub mod functions { pub use datafusion_functions::*; } -/// re-export of [`datafusion_functions_array`] crate, if "array_expressions" feature is enabled -pub mod functions_array { - #[cfg(feature = "array_expressions")] - pub use datafusion_functions_array::*; +/// re-export of [`datafusion_functions_nested`] crate, if "nested_expressions" feature is enabled Review Comment: Maybe we can leave a `pub use functions_array` here to help migration Something like ```rust #[deprecated(since = "41.0.0", note = "use datafusion-functions-nested instead")] pub mod functions_array { #[cfg(feature = "nested_expressions")] pub use datafusion_functions_nested::*; } ``` We could do something similar with the feature flags, but maybe that is too complicated to be worth it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org