alamb commented on code in PR #11575:
URL: https://github.com/apache/datafusion/pull/11575#discussion_r1686989128
##########
datafusion/core/src/datasource/file_format/csv.rs:
##########
@@ -1251,11 +1251,8 @@ mod tests {
"+-----------------------+",
"| 50 |",
"+-----------------------+"];
- let file_size = if cfg!(target_os = "windows") {
- 30 // new line on Win is '\r\n'
- } else {
- 20
- };
+
+ let file_size = std::fs::metadata("tests/data/one_col.csv")?.len() as
usize;
Review Comment:
I wonder how this test is passing on CI? In theory we run these tests on CI:
https://github.com/apache/datafusion/actions/runs/10044145872/job/27758535504
but somehow this test does not appear to run 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
