alamb commented on code in PR #11592:
URL: https://github.com/apache/datafusion/pull/11592#discussion_r1687065841
##########
datafusion/physical-expr-common/src/aggregate/groups_accumulator/accumulate.rs:
##########
@@ -132,7 +132,7 @@ impl NullState {
mut value_fn: F,
) where
T: ArrowPrimitiveType + Send,
- F: FnMut(usize, T::Native) + Send,
+ F: FnMut(usize, bool, T::Native) + Send,
Review Comment:
Can we please update the documentation to reflect this new argument and
explains what it means
##########
datafusion/physical-expr-common/src/aggregate/groups_accumulator/prim_op.rs:
##########
@@ -102,9 +102,13 @@ where
values,
opt_filter,
total_num_groups,
- |group_index, new_value| {
- let value = &mut self.values[group_index];
- (self.prim_fn)(value, new_value);
+ |group_index, was_valid, new_value| {
Review Comment:
It would be nice to add a test that covered this, if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
