RatulDawar commented on PR #21641:
URL: https://github.com/apache/datafusion/pull/21641#issuecomment-4253532550

   @adriangb I see here that you have me the probe side non-blocked for dynamic 
filter collection. But it maybe possilbe that in many cases where dynamic 
filtering could have caused a lot of datascan pruning is missed because of this 
change. 
   
   I feel intead of making it non-blocking, there should be a timeout something 
like [this](https://trino.io/docs/current/admin/dynamic-filtering.html).   
   
   Let me know what are your opinions on this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to