alamb commented on code in PR #11610:
URL: https://github.com/apache/datafusion/pull/11610#discussion_r1687143990
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -167,14 +164,8 @@ impl ExecutionPlan for CoalesceBatchesExec {
struct CoalesceBatchesStream {
/// The input plan
input: SendableRecordBatchStream,
- /// The input schema
- schema: SchemaRef,
- /// Minimum number of rows for coalesces batches
- target_batch_size: usize,
- /// Buffered batches
- buffer: Vec<RecordBatch>,
- /// Buffered row count
- buffered_rows: usize,
+ /// Buffer for combining batches
+ coalescer: BatchCoalescer,
Review Comment:
The whole point of the PR is to extract these fields and their management
into a struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
