geoffreyclaude commented on PR #19390: URL: https://github.com/apache/datafusion/pull/19390#issuecomment-4254410620
> Yeah agreed. @geoffreyclaude if you make a PR with just the benchmarks we can merge that immediately. Then the second commit would be its own PR. The rest I feel like we really need to look at the tradeoff of performance vs. complexity one by one and e.g. bake them off against https://github.com/apache/datafusion/pull/21547. @adriangb I cherry-picked the first two commits to dedicated PRs: - https://github.com/apache/datafusion/pull/21648 - https://github.com/apache/datafusion/pull/21649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
