alamb commented on issue #21650: URL: https://github.com/apache/datafusion/issues/21650#issuecomment-4254844117
> In my opinion we should avoid setting mutable state on ExecutionPlans (and related data structures) & move that to the inner streams. I think actually most of the state is already on the inner streams. I believe the core usecase for mutable state on ExecutionPlans is making connections between the inner streams. Sometimes this connection is for streams that come from the same `ExecutionPlan` -- e.g. the `CollectLeft` in joins Sometimes the connection is for streams for different `ExecutionPlan`s -- e.g dynamic filters need to source from a TopK operator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
