mbutrovich opened a new pull request, #21657:
URL: https://github.com/apache/datafusion/pull/21657

   ## Which issue does this PR close?
   
   - Closes #.
   
   ## Rationale for this change
   
   PR #21620 (commit 5c653bee5) ported 
`test_aggregate_dynamic_filter_parquet_e2e` from Rust to sqllogictest using 
`analyze_categories = 'rows'`, which includes exact pushdown metrics. These 
metrics are nondeterministic under parallel execution — the order in which 
Partial aggregates publish dynamic filter updates races against when the scan 
reads each partition — so the expected output is flaky.
   
   Noticed on #21629 ([CI 
run](https://github.com/apache/datafusion/actions/runs/24472961090/job/71518239089?pr=21629))
 and confirmed on main ([CI 
run](https://github.com/apache/datafusion/actions/runs/24467213913/job/71497866154)).
   
   ## What changes are included in this PR?
   
   Switch the `agg_dyn_e2e` test to `analyze_level = summary` + 
`analyze_categories = 'none'`, suppressing nondeterministic metrics. This 
matches the approach already used by the other aggregate dynamic filter tests 
in the same file. The original Rust test only asserted `matched < 4` (i.e. some 
pruning happened); the important invariant — that the `DynamicFilter [ 
column1@0 > 4 ]` text and pruning predicate are correct — is still verified.
   
   ## Are these changes tested?
   
   Yes — the test itself is what is being fixed.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to