Jefffrey commented on code in PR #20469:
URL: https://github.com/apache/datafusion/pull/20469#discussion_r3090554334
##########
datafusion/spark/src/function/array/slice.rs:
##########
@@ -78,17 +78,28 @@ impl ScalarUDFImpl for SparkSlice {
fn return_field_from_args(&self, args: ReturnFieldArgs) ->
Result<FieldRef> {
let nullable = args.arg_fields.iter().any(|f| f.is_nullable());
- Ok(Arc::new(Field::new(
- "slice",
- args.arg_fields[0].data_type().clone(),
- nullable,
- )))
+ let data_type = match args.arg_fields[0].data_type() {
+ DataType::Null => {
+ DataType::List(Arc::new(Field::new_list_field(DataType::Null,
true)))
+ }
+ dt => dt.clone(),
+ };
+
+ Ok(Arc::new(Field::new("slice", data_type, nullable)))
}
fn invoke_with_args(
&self,
mut func_args: ScalarFunctionArgs,
) -> Result<ColumnarValue> {
+ if func_args.args[0].data_type() == DataType::Null {
+ let len = match &func_args.args[0] {
+ ColumnarValue::Array(a) => a.len(),
+ ColumnarValue::Scalar(_) => func_args.number_rows,
+ };
+ return Ok(ColumnarValue::Array(list_null_array(len)));
Review Comment:
```suggestion
return Ok(ColumnarValue::Scalar(ScalarValue::new_null_list(
DataType::Null,
true,
1,
)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
