comphead commented on code in PR #21680:
URL: https://github.com/apache/datafusion/pull/21680#discussion_r3095357035
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -1265,24 +1262,26 @@ impl PushDecoderStreamState {
match data {
Ok(data) => {
if let Err(e) = self.decoder.push_ranges(ranges,
data) {
- return Some(Err(DataFusionError::from(e)));
+ return Some((Err(DataFusionError::from(e)),
self));
}
}
- Err(e) => return Some(Err(e)),
+ Err(e) => return Some((Err(e), self)),
}
}
Ok(DecodeResult::Data(batch)) => {
let mut timer =
self.baseline_metrics.elapsed_compute().timer();
self.copy_arrow_reader_metrics();
let result = self.project_batch(&batch);
timer.stop();
- return Some(result);
+ // Release the borrow on baseline_metrics before moving
self
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
