coderfender commented on PR #21561:
URL: https://github.com/apache/datafusion/pull/21561#issuecomment-4263938330

   @Dandandan true!  I also benchmarked through `cargo bench` and the results 
are similar  : 
   Benchmark PR is approved and ready to be merged to main for better 
comparison though
   
   ```
   group                                        groups_accumulator_hash_table   
       main
   -----                                        -----------------------------   
       ----
   count_distinct_groups g10000_high_skewed     1.00     50.0±0.69µs        ? 
?/sec    31.19 1558.7±19.53µs        ? ?/sec
   count_distinct_groups g10000_high_uniform    1.00     82.9±0.98µs        ? 
?/sec    19.69 1632.0±36.13µs        ? ?/sec
   count_distinct_groups g10000_low_skewed      1.00     48.5±0.48µs        ? 
?/sec    31.25 1514.7±31.43µs        ? ?/sec
   count_distinct_groups g10000_low_uniform     1.00     82.6±0.85µs        ? 
?/sec    19.34 1596.9±17.45µs        ? ?/sec
   count_distinct_groups g10000_mid_skewed      1.00     50.1±0.40µs        ? 
?/sec    30.94 1551.5±10.96µs        ? ?/sec
   count_distinct_groups g10000_mid_uniform     1.00     83.9±1.44µs        ? 
?/sec    19.10 1601.5±19.65µs        ? ?/sec
   count_distinct_groups g1000_high_skewed      1.00     48.6±0.86µs        ? 
?/sec    4.82    234.4±2.02µs        ? ?/sec
   count_distinct_groups g1000_high_uniform     1.00     80.7±0.72µs        ? 
?/sec    3.33    268.7±4.11µs        ? ?/sec
   count_distinct_groups g1000_low_skewed       1.00     32.4±0.22µs        ? 
?/sec    6.30    204.0±7.65µs        ? ?/sec
   count_distinct_groups g1000_low_uniform      1.00     80.5±0.86µs        ? 
?/sec    3.29    265.1±2.39µs        ? ?/sec
   count_distinct_groups g1000_mid_skewed       1.00     48.4±0.64µs        ? 
?/sec    4.75    229.6±1.71µs        ? ?/sec
   count_distinct_groups g1000_mid_uniform      1.00     80.7±0.61µs        ? 
?/sec    3.32    267.4±2.67µs        ? ?/sec
   count_distinct_groups g100_high_skewed       1.00     48.8±1.41µs        ? 
?/sec    1.80     87.8±1.53µs        ? ?/sec
   count_distinct_groups g100_high_uniform      1.00     80.7±0.88µs        ? 
?/sec    1.32    106.2±3.51µs        ? ?/sec
   count_distinct_groups g100_low_skewed        1.00     33.1±0.20µs        ? 
?/sec    1.65     54.7±0.52µs        ? ?/sec
   count_distinct_groups g100_low_uniform       1.00     81.0±1.66µs        ? 
?/sec    1.29    104.5±0.65µs        ? ?/sec
   count_distinct_groups g100_mid_skewed        1.00     48.0±0.64µs        ? 
?/sec    1.60     76.7±1.42µs        ? ?/sec
   count_distinct_groups g100_mid_uniform       1.00     80.2±0.64µs        ? 
?/sec    1.30    104.5±1.71µs        ? ?/sec
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to