BootstrapperSBL commented on issue #21642:
URL: https://github.com/apache/datafusion/issues/21642#issuecomment-4264277130
Took a quick look — the minimal fix matching the existing "preserve
predicate order" comment is to chain `child_predicates` first, then
`parent_predicates`, since unoptimized execution evaluates child filters before
parent ones:
```rust
let new_predicates = child_predicates
.into_iter()
.chain(parents_predicates)
.collect::<IndexSet<_>>()
.into_iter()
.collect::<Vec<_>>();
```
@asolimando happy to send a PR with that + a regression test using the
reporter's snippet (slots cleanly into `push_down_filter::tests`). The
hint-based design feels like a separate, larger discussion that shouldn't block
this minimal correctness fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
