comphead commented on code in PR #21713:
URL: https://github.com/apache/datafusion/pull/21713#discussion_r3105683963
##########
datafusion/physical-plan/src/spill/spill_manager.rs:
##########
@@ -160,9 +160,22 @@ impl SpillManager {
Ok(file.map(|f| (f, max_record_batch_size)))
}
- /// Reads a spill file as a stream. The file must be created by the
current `SpillManager`.
- /// This method will generate output in FIFO order: the batch appended
first
- /// will be read first.
+ /// Reads a spill file as a stream. The file must be created by the current
Review Comment:
what would happen if file created by another `SpillManager`? would the file
be ignored or crash?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
