Dandandan commented on code in PR #21586:
URL: https://github.com/apache/datafusion/pull/21586#discussion_r3106978096
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs:
##########
@@ -179,6 +181,133 @@ impl<B: ByteViewType> ByteViewGroupValueBuilder<B> {
}
}
+ fn vectorized_append_non_null_views(
+ &mut self,
+ array: &GenericByteViewArray<B>,
+ rows: &[usize],
+ ) {
+ let source_views = array.views();
+ self.views.reserve(rows.len());
+
+ if array.data_buffers().is_empty() {
+ self.views.extend(rows.iter().map(|&row| source_views[row]));
+ return;
+ }
+
+ let start_idx = self.views.len();
+ let mut pending = Vec::with_capacity(rows.len().saturating_add(1) / 2);
Review Comment:
I don't think we need to have this scratch space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
