Dandandan commented on PR #21613: URL: https://github.com/apache/datafusion/pull/21613#issuecomment-4276355662
> > Also sum and count compile to better code as this has a clear translation to (simd) instructions whereas count+sum in a single lkop probably does (still pretty fast, but...) generate less efficient code. > > Perhaps two separate loops (one for counts / one for sums) would improve this, but the CSE optimization (reducing state) is the larger improvement. > > Yeah this is what I was thinking of. But if the CSE is what is getting most of the benefit then optimizing avg maybe isn't worthwhile Could take a look, the rewrite would probably only moving a few lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
