xudong963 commented on code in PR #21705: URL: https://github.com/apache/datafusion/pull/21705#discussion_r3109155356
########## dev/release/README.md: ########## @@ -314,56 +309,85 @@ to all DataFusion crates. Download and unpack the official release tarball Verify that the Cargo.toml in the tarball contains the correct version -(e.g. `version = "38.0.0"`) and then publish the crates by running the following commands +(e.g. `version = "50.3.0"`) and then publish the crates by running the following commands ```shell -(cd datafusion/doc && cargo publish) -(cd datafusion/common-runtime && cargo publish) (cd datafusion/common && cargo publish) -(cd datafusion/proto-common && cargo publish) -(cd datafusion/macros && cargo publish) +(cd datafusion/common-runtime && cargo publish) +(cd datafusion/doc && cargo publish) (cd datafusion/expr-common && cargo publish) +(cd datafusion/macros && cargo publish) +(cd datafusion/proto-common && cargo publish) (cd datafusion/physical-expr-common && cargo publish) -(cd datafusion/functions-window-common && cargo publish) (cd datafusion/functions-aggregate-common && cargo publish) +(cd datafusion/functions-window-common && cargo publish) (cd datafusion/expr && cargo publish) (cd datafusion/execution && cargo publish) -(cd datafusion/physical-expr && cargo publish) (cd datafusion/functions && cargo publish) -(cd datafusion/functions-window && cargo publish) +(cd datafusion/physical-expr && cargo publish) (cd datafusion/functions-aggregate && cargo publish) +(cd datafusion/functions-window && cargo publish) (cd datafusion/physical-expr-adapter && cargo publish) -(cd datafusion/physical-plan && cargo publish) (cd datafusion/functions-nested && cargo publish) +(cd datafusion/physical-plan && cargo publish) (cd datafusion/session && cargo publish) -(cd datafusion/datasource && cargo publish) -(cd datafusion/catalog && cargo publish) -(cd datafusion/spark && cargo publish) (cd datafusion/sql && cargo publish) +(cd datafusion/datasource && cargo publish) (cd datafusion/optimizer && cargo publish) -(cd datafusion/functions-table && cargo publish) -(cd datafusion/datasource-json && cargo publish) -(cd datafusion/datasource-csv && cargo publish) -(cd datafusion/datasource-avro && cargo publish) +(cd datafusion/catalog && cargo publish) (cd datafusion/datasource-arrow && cargo publish) +(cd datafusion/datasource-avro && cargo publish) +(cd datafusion/datasource-csv && cargo publish) +(cd datafusion/datasource-json && cargo publish) (cd datafusion/pruning && cargo publish) (cd datafusion/datasource-parquet && cargo publish) -(cd datafusion/catalog-listing && cargo publish) +(cd datafusion/functions-table && cargo publish) (cd datafusion/physical-optimizer && cargo publish) +(cd datafusion/catalog-listing && cargo publish) (cd datafusion/core && cargo publish) (cd datafusion-cli && cargo publish) -(cd datafusion/substrait && cargo publish) -(cd datafusion/sqllogictest && cargo publish) (cd datafusion/proto && cargo publish) +(cd datafusion/spark && cargo publish) +(cd datafusion/substrait && cargo publish) (cd datafusion/ffi && cargo publish) +(cd datafusion/sqllogictest && cargo publish) +``` + +Crates.io publishing depends on crates dependency tree, this list might contain wrong order. +If it happens crates.io fails with wrong dependency message like below, just rerun all publishing commands. + +```shell +error: failed to prepare local package for uploading + +Caused by: + failed to select a version for the requirement `datafusion-proto = "^53.1.0"` + candidate versions found which didn't match: 53.0.0, 52.5.0, 52.4.0, ... + location searched: crates.io index + required by package `datafusion-ffi v53.1.0 (/private/tmp/apache-datafusion-53.1.0/datafusion/ffi)` +MacBook-Pro-135:apache-datafusion-53.1.0 ovoievodin$ (cd datafusion/proto && cargo publish) Review Comment: This line isn't needed. ########## dev/release/README.md: ########## @@ -248,19 +251,13 @@ review the release candidate. ./dev/release/verify-release-candidate.sh 50.3.0 1 ``` -#### If the Release is not Approved - -If the release is not approved, fix whatever the problem is, make a new release -candidate and try again. +#### If Changes Are Requested -Reminders: - -1. Update the changelog and create a new PR if there are any code changes, and merge it before creating the next RC. -2. Merge any fixes back to the `main` branch as well. +If the release is not approved or urgent backports requested, please start over from [here](#4-backporting-urgent-changes) #### If the Vote Passes: Announce the Result -Call the vote on the Arrow dev list by replying to the RC voting thread. The +Call the vote on the Apache Datafusion dev list by replying to the RC voting thread. The Review Comment: `DataFusion` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
