andygrove commented on PR #3989: URL: https://github.com/apache/datafusion-comet/pull/3989#issuecomment-4281791087
> > Is this a pure refactor, or does it fix any bugs related to the fallback logic? Asked a different way: should this be a `branch-15` backport candidate? > > This is a pure refactor. No functional changes. > > If I had been in less of a hurry to get a build out on Friday, this is how I would have implemented the fix for #3949 The reason why withInfo did not work initially is because of the way we were tagging shuffles when native shuffle was not supported, even though we did not fall back, because columnar shuffle was supported. We now figure out all the reasons for both native and columnar before calling withInfo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
