RatulDawar opened a new pull request, #21750:
URL: https://github.com/apache/datafusion/pull/21750

   ## Summary
   This PR adds unit tests to verify that `StringView` and `BinaryView` arrays 
are correctly compacted (garbage collected) before being spilled to disk. 
   
   The tests address [Issue 
#21683](https://github.com/apache/datafusion/issues/21683) by:
   1. Creating "bloated" batches with large underlying buffers.
   2. Slicing them to a small number of rows (1%).
   3. Spilling them to disk.
   4. Asserting that the resulting file size is small (proving that GC removed 
the unused "ghost" data).
   
   ## Test plan
   - Run `cargo test -p datafusion-physical-plan --lib 
spill::mod::tests::test_spill_file_size_gc_verification_string_view`
   - Run `cargo test -p datafusion-physical-plan --lib 
spill::mod::tests::test_spill_file_size_gc_verification_binary_view`
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to