kazuyukitanimura commented on PR #705: URL: https://github.com/apache/datafusion-comet/pull/705#issuecomment-2246355106
> I'm not entirely sure how this helps on the exec side, could you provide a short explanation? Otherwise lgtm Thanks @parthchandra When the native exec is enabled `CometDictionary` is still called that decode the dictionary. However the native exec does not use `CometDictionary` to read the values. So by moving the logic to the reader, it decodes only when we need it (scan-only case) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
