alamb commented on code in PR #11571:
URL: https://github.com/apache/datafusion/pull/11571#discussion_r1688773402
##########
datafusion/functions/src/math/log.rs:
##########
@@ -334,4 +341,94 @@ mod tests {
assert_eq!(args[0], lit(2));
assert_eq!(args[1], lit(3));
}
+
+ #[test]
+ fn test_log_output_ordering() {
+ // [Unordered, Ascending, Descending, Literal]
+ let orders = vec![
+ ExprProperties::new_unknown(),
+ ExprProperties::new_unknown().with_order(SortProperties::Ordered(
+ SortOptions {
+ descending: false,
+ nulls_first: true,
+ },
+ )),
+ ExprProperties::new_unknown().with_order(SortProperties::Ordered(
+ SortOptions {
+ descending: true,
+ nulls_first: true,
+ },
+ )),
+
ExprProperties::new_unknown().with_order(SortProperties::Singleton),
+ ];
+
+ let log = LogFunc::new();
+
+ // Test log(num)
+ for order in orders.iter().cloned() {
+ let result = log.output_ordering(&[order.clone()]).unwrap();
+ assert_eq!(result, order.sort_properties);
+ }
+
+ // Test log(base, num)
+ let mut results = Vec::with_capacity(orders.len() * orders.len());
+ for base_order in orders.iter() {
+ for num_order in orders.iter().cloned() {
+ let result = log
+ .output_ordering(&[base_order.clone(), num_order])
+ .unwrap();
+ results.push(result);
+ }
+ }
+ let expected = vec![
+ // base: Unordered
+ SortProperties::Unordered,
+ SortProperties::Unordered,
+ SortProperties::Unordered,
+ SortProperties::Unordered,
+ // base: Ascending, num: Unordered
+ SortProperties::Unordered,
+ // base: Ascending, num: Ascending
+ SortProperties::Unordered,
+ // base: Ascending, num: Descending
+ SortProperties::Ordered(SortOptions {
+ descending: true,
+ nulls_first: true,
+ }),
+ // base: Ascending, num: Literal
+ SortProperties::Ordered(SortOptions {
+ descending: true,
+ nulls_first: true,
+ }),
+ // base: Descending, num: Unordered
+ SortProperties::Unordered,
+ // base: Descending, num: Ascending
+ SortProperties::Ordered(SortOptions {
+ descending: false,
+ nulls_first: true,
+ }),
+ // base: Descending, num: Descending
+ SortProperties::Unordered,
+ // base: Descending, num: Literal
+ SortProperties::Ordered(SortOptions {
+ descending: false,
+ nulls_first: true,
+ }),
+ // base: Literal, num: Unordered
+ SortProperties::Unordered,
+ // base: Literal, num: Ascending
+ SortProperties::Ordered(SortOptions {
+ descending: false,
+ nulls_first: true,
+ }),
+ // base: Literal, num: Descending
+ SortProperties::Ordered(SortOptions {
+ descending: true,
+ nulls_first: true,
+ }),
+ // base: Literal, num: Literal
+ SortProperties::Singleton,
+ ];
+ assert_eq!(results, expected);
+ }
Review Comment:
> output_ordering() API of scalar functions are experimental
What do you mean by "experimental"? If that is the case perhaps we can
update the documentation to explain what that means -- I don't see any mention
of it
https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#method.output_ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
