iffyio commented on code in PR #2297:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2297#discussion_r3116801767
##########
src/parser/mod.rs:
##########
@@ -12170,7 +12170,20 @@ impl<'a> Parser<'a> {
self.expect_token(&Token::RParen)?;
Ok(DataType::FixedString(character_length))
}
- Keyword::TEXT => Ok(DataType::Text),
+ Keyword::TEXT => {
+ if dialect.supports_text_type_modifiers() {
Review Comment:
can we always have the parser accept the modifier if it shows up in the
statement? given that its optional, I think that would match the behavior of
similar datatypes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
