andygrove commented on issue #1637:
URL:
https://github.com/apache/datafusion-comet/issues/1637#issuecomment-4288617664
I did a quick grep of ignored tests in 4.0.1 diff:
```
% grep "IgnoreComet.*(" dev/diffs/4.0.1.diff
+ IgnoreComet("TODO:
https://github.com/apache/datafusion-comet/issues/1839";)) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+ IgnoreComet("TODO:
https://github.com/apache/datafusion-comet/issues/1839";)) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";),
+ IgnoreComet("TODO:
https://github.com/apache/datafusion-comet/issues/1839";)) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3442";))
{
+ IgnoreComet("Comet explain output is different")) {
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
+ IgnoreComet("TODO: Comet SMJ doesn't support spill yet")) {
+ IgnoreComet("Comet SMJ doesn't spill yet")) {
+ IgnoreComet("TODO: native CometSort does not update peak execution
memory")) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+ IgnoreComet("Comet doesn't completely support datetime rebase mode
yet")) {
+ test("FileScan description", IgnoreComet("Comet doesn't use BatchScan")) {
+ test("SPARK-47289: extended explain info", IgnoreComet("Comet plan
extended info is different")) {
+ IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+ IgnoreComet("Comet shuffle changes shuffle partition size")) {
+ IgnoreComet("Comet shuffle changes shuffle partition size")) {
+ test("Scalar subquery", IgnoreComet("Comet shuffle changes shuffle
metrics")) {
+ test("Scalar subquery in later stages", IgnoreComet("Comet shuffle
changes shuffle metrics")) {
+ test("multiple joins", IgnoreComet("Comet shuffle changes shuffle
metrics")) {
+ test("multiple joins with aggregate", IgnoreComet("Comet shuffle changes
shuffle metrics")) {
+ test("multiple joins with aggregate 2", IgnoreComet("Comet shuffle
changes shuffle metrics")) {
+ test("Exchange reuse", IgnoreComet("Comet shuffle changes shuffle
metrics")) {
+ test("Exchange reuse with subqueries", IgnoreComet("Comet shuffle changes
shuffle metrics")) {
+ IgnoreComet("Comet shuffle changes shuffle metrics")) {
+ IgnoreComet("Comet shuffle has different partition metrics")) {
+ IgnoreComet("Comet shuffle changes the metrics")) {
+ IgnoreComet("Comet shuffle changes partition size")) {
+ IgnoreComet("Comet shuffle changes the partition size")) {
+ IgnoreComet("Comet shuffle changes shuffle metrics")) {
+ IgnoreComet("Comet shuffle changes shuffle metrics")) {
+ IgnoreComet("Comet shuffle changes shuffle metrics")) {
+ IgnoreComet("TODO: Comet SMJ to BHJ by AQE")) {
+ IgnoreComet("Comet doesn't support RLE encoding yet")) {
+ IgnoreCometNativeScan("Native scans do not support the tested
accumulator")) {
+ test("filter pushdown - StringPredicate", IgnoreCometNativeScan("cannot
be pushed down")) {
+ IgnoreCometNativeScan("Comet has different push-down behavior")) {
+ IgnoreComet("Comet doesn't support Parquet column index yet")) {
+ IgnoreCometNativeScan("Native scans do not support the tested
accumulator")) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
+ IgnoreComet("Comet doesn't support DELTA encoding yet")) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
+ IgnoreComet("Comet doesn't work with vectorizedReaderEnabled =
false")) {
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
+ Seq(IgnoreCometNativeDataFusion(
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";))
{
+
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3321";)
+ IgnoreComet("Comet does not use FileScan")) {
+ IgnoreComet("Spark uses row-based Parquet reader while Comet is
vectorized")) {
+ IgnoreComet("Comet explain output is different")) {
+ IgnoreComet("Comet does not support reading non UTF-8 strings")) {
```
At first glance, most of these do not seem like serious issues.
Perhaps we can remove experimental status at this point. @kazuyukitanimura
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
