vaibhawvipul commented on code in PR #585:
URL: https://github.com/apache/datafusion-comet/pull/585#discussion_r1689565989
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -982,23 +981,80 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
None
case EqualTo(left, right) =>
- val leftExpr = exprToProtoInternal(left, inputs)
- val rightExpr = exprToProtoInternal(right, inputs)
+ // this is a workaround for handling -0.0 in double and float
+ // untill https://github.com/apache/datafusion/issues/11108 is fixed
+ val leftZero = Literal.default(left.dataType)
+ val rightZero = Literal.default(right.dataType)
+ val negZeroLeft = UnaryMinus(leftZero)
+ val negZeroRight = UnaryMinus(rightZero)
+
+ def buildEqualExpr(
+ leftExpr: Option[Expr],
+ rightExpr: Option[Expr]): Option[ExprOuterClass.Expr] = {
+ if (leftExpr.isDefined && rightExpr.isDefined) {
+ Some(
+ ExprOuterClass.Expr
+ .newBuilder()
+ .setEq(
+ ExprOuterClass.Equal
+ .newBuilder()
+ .setLeft(leftExpr.get)
+ .setRight(rightExpr.get))
+ .build())
+ } else {
+ withInfo(expr, left, right)
+ None
+ }
+ }
+ if ((left.dataType == DoubleType &&
+ right.dataType == DoubleType) ||
+ (left.dataType == FloatType &&
+ right.dataType == FloatType)) {
+ (left, right) match {
+ case (`negZeroLeft`, `negZeroRight`) =>
+ return buildEqualExpr(
+ exprToProtoInternal(Abs(left).child, inputs),
+ exprToProtoInternal(Abs(right).child, inputs))
+ case (`negZeroLeft`, _) =>
+ return buildEqualExpr(
+ exprToProtoInternal(Abs(left).child, inputs),
+ exprToProtoInternal(right, inputs))
+ case (_, `negZeroRight`) =>
+ return buildEqualExpr(
+ exprToProtoInternal(left, inputs),
+ exprToProtoInternal(Abs(right).child, inputs))
+ case _ =>
+ val doubleNan = Literal(Double.NaN, DoubleType)
+ val floatNan = Literal(Float.NaN, FloatType)
+
+ if ((left.nullable && !right.nullable) &&
+ (left != negZeroLeft && right != negZeroRight) &&
+ (left != leftZero && right != rightZero) &&
+ (left != doubleNan && right != doubleNan) &&
+ (left != floatNan && right != floatNan)) {
Review Comment:
added comments to explain this. @kazuyukitanimura
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
