connec commented on PR #11633: URL: https://github.com/apache/datafusion/pull/11633#issuecomment-2248449931
Thank you @alamb! There's one other `TODO` in the code that I wondered if you have thoughts on: https://github.com/apache/datafusion/blob/debfd19e1c2d5bf0afb51c94879981478bf01733/datafusion/core/src/datasource/physical_plan/csv.rs#L97-L103 I imagine this may be at least somewhat desirable/intentional as part of ensuring crate boundaries? An alternative could be to, e.g., use `CsvOptions` (or `csv::Format`, or...) rather than "spreading" their fields into so many places. It's just boilerplate at the end of the day though, so I'm also happy to just remove that `TODO`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
