alamb commented on code in PR #11640: URL: https://github.com/apache/datafusion/pull/11640#discussion_r1690354569
########## pre-commit.sh: ########## @@ -57,13 +57,7 @@ fi # 1. cargo clippy echo -e "$(GREEN INFO): cargo clippy ..." - -# Cargo clippy always return exit code 0, and `tee` doesn't work. -# So let's just run cargo clippy. -cargo clippy --all-targets --workspace --features avro,pyarrow -- -D warnings -pushd datafusion-cli -cargo clippy --all-targets --all-features -- -D warnings -popd +./ci/scripts/rust_clippy.sh Review Comment: I also double checked that this is the same as used in CI: https://github.com/apache/datafusion/blob/bcf715c892f74d48bdbef54ac7165358be6fb741/.github/workflows/rust.yml#L486 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
