findepi commented on PR #11516: URL: https://github.com/apache/datafusion/pull/11516#issuecomment-2248899510
re: SessionProvider the trait describes something that doesn't _provide session_, it describes something that _is session_. However, same think can be said about TableProvider or CatalogProvider. I don't have an answer to the consistency argument... i can change, this is not a big deal. @alamb @jayzhan211 @cisaacson @phillipleblanc @Omega359 let's just make sure we have agreement to avoid unnecessary back and forth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
