andygrove commented on code in PR #704:
URL: https://github.com/apache/datafusion-comet/pull/704#discussion_r1691428817
##########
native/spark-expr/src/cast.rs:
##########
@@ -1746,35 +1844,92 @@ mod tests {
#[test]
#[cfg_attr(miri, ignore)] // test takes too long with miri
fn timestamp_parser_test() {
+ let tz = &timezone::Tz::from_str("UTC").unwrap();
// write for all formats
assert_eq!(
- timestamp_parser("2020", EvalMode::Legacy).unwrap(),
+ timestamp_parser("2020", EvalMode::Legacy, tz).unwrap(),
Review Comment:
Could you also add tests for 3-digit year
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
