Michael-J-Ward commented on PR #768: URL: https://github.com/apache/datafusion-python/pull/768#issuecomment-2250309086
> In regards to AggregateBuilder would you be willing to wait one more release? We just merged in https://github.com/apache/datafusion/pull/11550 which I'm guessing will be in datafusion 41.0. First, excellent upstream PR. I literally have "improve upstream Builder API" in my post upgrade hit-list, so I'm very happy to see that you've knocked it out. Second, we can absolutely wait till 41. I've been slow to the 40 upgrade, so let's get it out the door first. > What do you think - should we update count_star or maybe just add to the docstring to say that None arguments is a special case that ignores distinct? Could `count(None, distinct = True)` map to `count(lit(1), distinct=True)` instead of `count_star()`? And before that, do we need to support `count(None)` at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
